ESX Snapshots without metrics

Since version 2.0 of checkmk the service check “ESX Snapshots” only has the metrics age and age_oldest if the threshold parameters are set.

Why was if params.get('age') else None added in this line?

https://github.com/tribe29/checkmk/commit/1a5e8f9755249f4b5dbae481ef044d159b5e6388#r105760275

1 Like

I think the easy answer is - the code was ported from someone without real experience in daily usage of an ESX system. If i write a check or port a check for a system i don’t know, most time the check is missing some important things.
In the end the code is strange and makes no sense this way.

The thing is that the metric did not have this limitation in checkmk 1.6.

The if statement was added in 2.0 and I cannot think of a reason to do this.