Windows agent 1.6 - YML setting - misleading comment for allowed plugin file extensions

Hi CMK-Team,

I have a small proposal for the comment in the Windows agent YML file.
The explanation of the default value for extensions being executed is imho misleading:

# Do only execute programs and scripts with
# the following suffixes (in local and plugins).
# Per default *all extensions* except txt and dir
# are being executed.
# execute: exe bat vbs cmd ps1

could be understood as the agent executes everything per default.

But in fact, it only executes all of the extensions which are named in the commented line below.
Naive individuals like me :slight_smile: could understand that you only have to uncomment the line “execute” if you want to limit the executable plugins to something other than “all extensions”.
Furthermore, as soon as you have changed the line, you lost the information about the default setting.

Proposal:

# Per default the extensions exe/bat/vbs/cmd/ps1
# are being executed.

Regards,
Simon

PS: Why not include also .py to the defaults?

1 Like

I think the 1.7 agent from the daily builds has already py included. As the agent brings his own python interpreter then.

1 Like
  • Default settings you will find in the Program Files(x86)\checkmk\service\check_mk.yml
  • py extension is absent to simulate the behavior of the agent 1.5. Probably, this was not so good idea.
  • In 1.7 we will change this, of course(as Andreas mentioned already).

And your proposal is absolutely correct: The text is not clear

  • I will fix texts in 1.6/1.7
  • Introducing py extension in 1.6 by default requires an approve
2 Likes

Thanks @SergejKipnis !
BR, Simon