BUG: 2.2 & 2.3 docsis_channels_upstream - parameters inconsistency between ruleset and default_parameters

[oliverj]

Checkmk version:
2.2.0p23cee

OS version of Checkmk server or monitored system:
Appliance 1.6.8

Description of the problem : Problem with Check docsis_channels_upstream

Error message and/or output from below commands:

Invalid check parameter: Undefined key 'corrected' in the dictionary. Allowed are signal_noise, correcteds, uncorrectables.
Variable: checkgroup_parameters:docsis_channels_upstream
Parameters:
{'corrected': (5.0, 8.0),
 'signal_noise': (28.0, 23.0),
 'uncorrectable': (1.0, 2.0)}

I have not entered any real values, only values for testing.

Invalid check parameter: Undefined key 'corrected' in the dictionary. Allowed are signal_noise, correcteds, uncorrectables.
Variable: checkgroup_parameters:docsis_channels_upstream
Parameters:
{'corrected': (5.0, 8.0),
 'correcteds': (85.0, 95.0),
 'signal_noise': (28.0, 23.0),
 'uncorrectable': (1.0, 2.0),
 'uncorrectables': (90.0, 95.0)}

After I changed corrected to correcteds in lines 50,129,141 and uncorrectable to uncorrectables in lines 51,132,145 in the file share\check_mk\checks\docsis_channels_upstream, the individual parameters work. I therefore assume that there is an error.

factory_settings["docsis_channels_upstream_default_levels"] = {
    "signal_noise": (10.0, 5.0),  # dB
    "correcteds": (5.0, 8.0),  # Percent
    "uncorrectables": (1.0, 2.0),  # Percent
}

        for what, counter in [
            (
                "unerrored",
                int(unerroreds),
            ),
            (
                "correcteds",
                int(correcteds),
            ),
            ("uncorrectables", int(uncorrectables)),
        ]:

           for what, title in [
                (
                    "correcteds",
                    "corrected errors",
                ),
                (
                    "uncorrectables",
                    "uncorrectable errors",
                ),
            ]:

Kind regards,
Oliver

[oliverj]

Checkmk version:
2.2.0p30cee

OS version of Checkmk server or monitored system:
Appliance 1.6.9

Description of the problem : Problem with Check docsis_channels_upstream

The values for “Corrected codewords” and “Uncorrectable codewords” are not working. The Levels for “signal/noise ratio” are working.

Any ideas?

Kind regards,
Oliver

[andreas-doehler (Andreas)]

Problem is again - what you mentioned in the first post - the wrong names of the parameter variables.
This problem is also existing in 2.3
check_default_parameters

    check_default_parameters={
        "signal_noise": (10.0, 5.0),  # dB
        "corrected": (5.0, 8.0),  # Percent
        "uncorrectable": (1.0, 2.0),  # Percent
    },

Parameters from ruleset

            (
                "correcteds",
                Tuple(
                    title=_("Levels for rate of corrected errors"),
                    elements=[
                        Percentage(title=_("Warning at"), default_value=5.0),
                        Percentage(title=_("Critical at"), default_value=8.0),
                    ],
                ),
            ),
            (
                "uncorrectables",
                Tuple(
                    title=_("Levels for rate of uncorrectable errors"),
                    elements=[
                        Percentage(title=_("Warning at"), default_value=1.0),
                        Percentage(title=_("Critical at"), default_value=2.0),
                    ],
                ),
            ),

[oliverj]

The problem can be solved by making the following changes

Line 29 => “corrected”
Line 39 => “uncorrectable”

to the file

/omd/versions/2.2.0p31.cee/lib/python3/cmk/gui/plugins/wato/check_parameters/docsis_channels_upstream.py
.

@andreas-doehler: right, Version 2.3 is buggy too.

Best regards,
Oliver