[Check_mk (english)] Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Archive checkmk-en
1

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local
checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

···

--

Beste Grüße

Ghassan Elrayah
Mail: ghassan.elrayah@live.de

2

Hi Ghassan,

That's no local folder, that's a shared folder in which someone did a 'mkdir local'.

Check the following path, this is the correct folder for local checks.
/omd/sites/{sitename}/local/share/check_mk/checks

Arno.

···

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 10:26
To: checkmk-en@lists.mathias-kettner.de
Subject: [Check_mk (english)] Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--

Beste Grüße

Ghassan Elrayah
Mail: ghassan.elrayah@live.de

_______________________________________________
checkmk-en mailing list
checkmk-en@lists.mathias-kettner.de
Manage your subscription or unsubscribe
https://lists.mathias-kettner.de/cgi-bin/mailman/listinfo/checkmk-en

3

Hi,

yes my local checks are all in /usr/lib/check_mk_agent/local on the
agents. I am talking about this particular file in check-mk instance:

/omd/sites/{sitename}/share/check_mk/checks/local

which is a python script, at line 184 there is an indentation error. This caused all my local checks on the agents not to be discovered.

On chekc-mk instance when you run "cmk -vII host or cmk -O host" i get an error:
Error in plugin file /omd/sites/{sitename}/share/check_mk/checks/local: expected an indented block (<unknown>, line 184)

the return statement is not indented. I fixed it now manually to get my local checks back and looks good now, but I think this is a bug and I already reported it.

···

On 11/8/19 10:54 AM, Arno Wijnhoven wrote:

Hi Ghassan,

That's no local folder, that's a shared folder in which someone did a 'mkdir local'.

Check the following path, this is the correct folder for local checks.
/omd/sites/{sitename}/local/share/check_mk/checks

Arno.

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 10:26
To: checkmk-en@lists.mathias-kettner.de
Subject: [Check_mk (english)] Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--

Beste Grüße

Ghassan Elrayah
Mail: ghassan.elrayah@live.de

4

The logic of this function in at line 184 is also not correct, if I
understand it correctly the following:

···

--------------------------------------------
def inventory_local(parsed):
if None in parsed:

 return \[\(key, \{\}\) for key in parsed\]

--------------------------------------------

should be:

--------------------------------------------
def inventory_local(parsed):
if None not in parsed:

     return \[\(key, \{\}\) for key in parsed\]

--------------------------------------------

On 11/8/19 11:06 AM, Ghassan Elrayah wrote:

Hi,

yes my local checks are all in /usr/lib/check_mk_agent/local on the
agents. I am talking about this particular file in check-mk instance:

/omd/sites/{sitename}/share/check_mk/checks/local

which is a python script, at line 184 there is an indentation error. This caused all my local checks on the agents not to be discovered.

On chekc-mk instance when you run "cmk -vII host or cmk -O host" i get an error:
Error in plugin file /omd/sites/{sitename}/share/check_mk/checks/local: expected an indented block (<unknown>, line 184)

the return statement is not indented. I fixed it now manually to get my local checks back and looks good now, but I think this is a bug and I already reported it.

On 11/8/19 10:54 AM, Arno Wijnhoven wrote:

Hi Ghassan,

That's no local folder, that's a shared folder in which someone did a 'mkdir local'.

Check the following path, this is the correct folder for local checks.
/omd/sites/{sitename}/local/share/check_mk/checks

Arno.

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 10:26
To: checkmk-en@lists.mathias-kettner.de
Subject: [Check_mk (english)] Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--

Beste Grüße

Ghassan Elrayah
Mail: ghassan.elrayah@live.de

5

Terribly sorry, misunderstood.

In my 1.6.0p5 test setup (no update, clean install) the file is present as well.
But in my case it just works. I got one local check in that setup and it's working as intended, no errors.

Arno.

···

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 11:14
To: checkmk-en@lists.mathias-kettner.de
Subject: Re: [Check_mk (english)] Local checks vanished after update from 1.5.0p22 to 1.6.0p5

The logic of this function in at line 184 is also not correct, if I understand it correctly the following:

--------------------------------------------
def inventory_local(parsed):
if None in parsed:

 return \[\(key, \{\}\) for key in parsed\]

--------------------------------------------

should be:

--------------------------------------------
def inventory_local(parsed):
if None not in parsed:

     return \[\(key, \{\}\) for key in parsed\]

--------------------------------------------

On 11/8/19 11:06 AM, Ghassan Elrayah wrote:

Hi,

yes my local checks are all in /usr/lib/check_mk_agent/local on the
agents. I am talking about this particular file in check-mk instance:

/omd/sites/{sitename}/share/check_mk/checks/local

which is a python script, at line 184 there is an indentation error. This caused all my local checks on the agents not to be discovered.

On chekc-mk instance when you run "cmk -vII host or cmk -O host" i get an error:
Error in plugin file
/omd/sites/{sitename}/share/check_mk/checks/local: expected an
indented block (<unknown>, line 184)

the return statement is not indented. I fixed it now manually to get my local checks back and looks good now, but I think this is a bug and I already reported it.

On 11/8/19 10:54 AM, Arno Wijnhoven wrote:

Hi Ghassan,

That's no local folder, that's a shared folder in which someone did a 'mkdir local'.

Check the following path, this is the correct folder for local checks.
/omd/sites/{sitename}/local/share/check_mk/checks

Arno.

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On
Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 10:26
To: checkmk-en@lists.mathias-kettner.de
Subject: [Check_mk (english)] Local checks vanished after update from
1.5.0p22 to 1.6.0p5

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--

Beste Grüße

Ghassan Elrayah
Mail: ghassan.elrayah@live.de

_______________________________________________
checkmk-en mailing list
checkmk-en@lists.mathias-kettner.de
Manage your subscription or unsubscribe
https://lists.mathias-kettner.de/cgi-bin/mailman/listinfo/checkmk-en

6

No problem at all, are local checks on the agents being discovered with
the original code?

···

On 11/8/19 11:19 AM, Arno Wijnhoven wrote:

Terribly sorry, misunderstood.

In my 1.6.0p5 test setup (no update, clean install) the file is present as well.
But in my case it just works. I got one local check in that setup and it's working as intended, no errors.

Arno.

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 11:14
To: checkmk-en@lists.mathias-kettner.de
Subject: Re: [Check_mk (english)] Local checks vanished after update from 1.5.0p22 to 1.6.0p5

The logic of this function in at line 184 is also not correct, if I understand it correctly the following:

--------------------------------------------
def inventory_local(parsed):
   if None in parsed:

   return [(key, {}) for key in parsed]
--------------------------------------------

should be:

--------------------------------------------
def inventory_local(parsed):
   if None not in parsed:

   return [(key, {}) for key in parsed]
--------------------------------------------

On 11/8/19 11:06 AM, Ghassan Elrayah wrote:

Hi,

yes my local checks are all in /usr/lib/check_mk_agent/local on the
agents. I am talking about this particular file in check-mk instance:

/omd/sites/{sitename}/share/check_mk/checks/local

which is a python script, at line 184 there is an indentation error. This caused all my local checks on the agents not to be discovered.

On chekc-mk instance when you run "cmk -vII host or cmk -O host" i get an error:
Error in plugin file
/omd/sites/{sitename}/share/check_mk/checks/local: expected an
indented block (<unknown>, line 184)

the return statement is not indented. I fixed it now manually to get my local checks back and looks good now, but I think this is a bug and I already reported it.

On 11/8/19 10:54 AM, Arno Wijnhoven wrote:

Hi Ghassan,

That's no local folder, that's a shared folder in which someone did a 'mkdir local'.

Check the following path, this is the correct folder for local checks.
/omd/sites/{sitename}/local/share/check_mk/checks

Arno.

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On
Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 10:26
To: checkmk-en@lists.mathias-kettner.de
Subject: [Check_mk (english)] Local checks vanished after update from
1.5.0p22 to 1.6.0p5

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--

Beste Grüße

Ghassan Elrayah
Mail: ghassan.elrayah@live.de

7

Sorry, I'm not using agents so I don't know.

···

-----Original Message-----
From: Ghassan Elrayah <ghassan.elrayah@live.de>
Sent: vrijdag 8 november 2019 11:27
To: Arno Wijnhoven <arnow@vsnsystemen.nl>; checkmk-en@lists.mathias-kettner.de
Subject: Re: [Check_mk (english)] Local checks vanished after update from 1.5.0p22 to 1.6.0p5

No problem at all, are local checks on the agents being discovered with the original code?

On 11/8/19 11:19 AM, Arno Wijnhoven wrote:

Terribly sorry, misunderstood.

In my 1.6.0p5 test setup (no update, clean install) the file is present as well.
But in my case it just works. I got one local check in that setup and it's working as intended, no errors.

Arno.

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On
Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 11:14
To: checkmk-en@lists.mathias-kettner.de
Subject: Re: [Check_mk (english)] Local checks vanished after update
from 1.5.0p22 to 1.6.0p5

The logic of this function in at line 184 is also not correct, if I understand it correctly the following:

--------------------------------------------
def inventory_local(parsed):
   if None in parsed:

   return [(key, {}) for key in parsed]
--------------------------------------------

should be:

--------------------------------------------
def inventory_local(parsed):
   if None not in parsed:

   return [(key, {}) for key in parsed]
--------------------------------------------

On 11/8/19 11:06 AM, Ghassan Elrayah wrote:

Hi,

yes my local checks are all in /usr/lib/check_mk_agent/local on the
agents. I am talking about this particular file in check-mk instance:

/omd/sites/{sitename}/share/check_mk/checks/local

which is a python script, at line 184 there is an indentation error. This caused all my local checks on the agents not to be discovered.

On chekc-mk instance when you run "cmk -vII host or cmk -O host" i get an error:
Error in plugin file
/omd/sites/{sitename}/share/check_mk/checks/local: expected an
indented block (<unknown>, line 184)

the return statement is not indented. I fixed it now manually to get my local checks back and looks good now, but I think this is a bug and I already reported it.

On 11/8/19 10:54 AM, Arno Wijnhoven wrote:

Hi Ghassan,

That's no local folder, that's a shared folder in which someone did a 'mkdir local'.

Check the following path, this is the correct folder for local checks.
/omd/sites/{sitename}/local/share/check_mk/checks

Arno.

-----Original Message-----
From: checkmk-en <checkmk-en-bounces@lists.mathias-kettner.de> On
Behalf Of Ghassan Elrayah
Sent: vrijdag 8 november 2019 10:26
To: checkmk-en@lists.mathias-kettner.de
Subject: [Check_mk (english)] Local checks vanished after update
from
1.5.0p22 to 1.6.0p5

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--

Beste Grüße

Ghassan Elrayah
Mail: ghassan.elrayah@live.de

8

`Further more the logic of this function in /omd/sites/${site}/share/check_mk/checks/local at line 181 is confusing me, if I understand it correctly the following:
``


``-------------------------------------------- ``

``def inventory_local(parsed): ``

``    if None in parsed: ``

return [(key, {}) for key in parsed]

-------------------------------------------- 


``should be: ``

--------------------------------------------

def inventory_local(parsed):

if None not in parsed:


``        return [(key, {}) for key in parsed] ``

``--------------------------------------------`

<details class='elided'>
<summary title='Show trimmed content'>&#183;&#183;&#183;</summary>

-------- Forwarded Message --------
Hi,
I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

Subject:
Local checks vanished after update from 1.5.0p22 to 1.6.0p5
Date:
Fri, 8 Nov 2019 10:25:43 +0100
From:
Ghassan Elrayah
To:

<ghassan.elrayah@live.de>checkmk-en@lists.mathias-kettner.de
<checkmk-en@lists.mathias-kettner.de>

```

-- Beste Grüße
Ghassan Elrayah
Mail:
```
ghassan.elrayah@live.de

</details>
9

I see:

def inventory_local(parsed):

if None in parsed:

output = parsed[None][0]

raise MKGeneralException(“Invalid line in agent section <<>>: %r” % (output,))

return [(key, {}) for key in parsed]

Which appears correct to me.

···

From: checkmk-en checkmk-en-bounces@lists.mathias-kettner.de
On Behalf Of Ghassan Elrayah
Sent: Friday, November 8, 2019 5:57 AM
To: checkmk-en@lists.mathias-kettner.de
Subject: [Check_mk (english)] Fwd: Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Further more the logic of this function in /omd/sites/${site}/share/check_mk/checks/local at line 181 is confusing me, if I understand it correctly the following:

--------------------------------------------

def inventory_local(parsed):

if None in parsed:

return [(key, {}) for key in parsed]

--------------------------------------------

should be:

--------------------------------------------

def inventory_local(parsed):

if None not in parsed:

return [(key, {}) for key in parsed]

--------------------------------------------

-------- Forwarded Message --------

Subject:

Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Date:

Fri, 8 Nov 2019 10:25:43 +0100

From:

Ghassan Elrayah ghassan.elrayah@live.de

To:

checkmk-en@lists.mathias-kettner.de
checkmk-en@lists.mathias-kettner.de

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--


Beste Grüße


Ghassan Elrayah

Mail: ghassan.elrayah@live.de


</details>
10

This appears correct indeed, unfortunately it is not in my instance. I am running distributed monitoring with a master and 8 slaves, these two lines are missing in all the instances:

    output = parsed[None][0]

    raise MKGeneralException("Invalid line in agent section <<<local>>>: %r" % (output,))

I will modify it locally.

···

On 11/8/19 1:40 PM, wrote:

Matthew.Stier@us.fujitsu.com

I see:

def inventory_local(parsed):

if None in parsed:

output = parsed[None][0]

raise MKGeneralException(“Invalid line in agent section <<>>: %r” % (output,))

return [(key, {}) for key in parsed]

Which appears correct to me.

From: checkmk-en
Ghassan Elrayah
Friday, November 8, 2019 5:57 AM
[Check_mk (english)] Fwd: Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Further more the logic of this function in /omd/sites/${site}/share/check_mk/checks/local at line 181 is confusing me, if I understand it correctly the following:

--------------------------------------------

def inventory_local(parsed):

if None in parsed:

return [(key, {}) for key in parsed]

--------------------------------------------

should be:

--------------------------------------------

def inventory_local(parsed):

if None not in parsed:

return [(key, {}) for key in parsed]

--------------------------------------------

-------- Forwarded Message --------

Subject:

Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Date:

Fri, 8 Nov 2019 10:25:43 +0100

From:

Ghassan Elrayah
ghassan.elrayah@live.de

To:

checkmk-en@lists.mathias-kettner.de
checkmk-en@lists.mathias-kettner.de

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--

Beste Grüße

Ghassan Elrayah

Mail: ghassan.elrayah@live.de

checkmk-en-bounces@lists.mathias-kettner.deOn Behalf Of
Sent:
To:
checkmk-en@lists.mathias-kettner.de
Subject:


-- Beste Grüße
Ghassan Elrayah
Mail:

ghassan.elrayah@live.de

11

`I reinstalled all check_mk instances. It looks good now.

Thanks`

···

On 11/8/19 1:48 PM, Ghassan Elrayah wrote:

This appears correct indeed, unfortunately it is not in my instance. I am running distributed monitoring with a master and 8 slaves, these two lines are missing in all the instances:

    output = parsed[None][0]

    raise MKGeneralException("Invalid line in agent section <<<local>>>: %r" % (output,))

I will modify it locally.

On 11/8/19 1:40 PM, wrote:

Matthew.Stier@us.fujitsu.com

I see:

def inventory_local(parsed):

if None in parsed:

output = parsed[None][0]

raise MKGeneralException(“Invalid line in agent section <<>>: %r” % (output,))

return [(key, {}) for key in parsed]

Which appears correct to me.

From: checkmk-en
Ghassan Elrayah
Friday, November 8, 2019 5:57 AM
[Check_mk (english)] Fwd: Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Further more the logic of this function in /omd/sites/${site}/share/check_mk/checks/local at line 181 is confusing me, if I understand it correctly the following:

--------------------------------------------

def inventory_local(parsed):

if None in parsed:

return [(key, {}) for key in parsed]

--------------------------------------------

should be:

--------------------------------------------

def inventory_local(parsed):

if None not in parsed:

return [(key, {}) for key in parsed]

--------------------------------------------

-------- Forwarded Message --------

Subject:

Local checks vanished after update from 1.5.0p22 to 1.6.0p5

Date:

Fri, 8 Nov 2019 10:25:43 +0100

From:

Ghassan Elrayah
ghassan.elrayah@live.de

To:

checkmk-en@lists.mathias-kettner.de
checkmk-en@lists.mathias-kettner.de

Hi,

I just updated check-mk-raw from 1.5.0p22 to 1.6.0p5. all my local checks vanished. There is an indentation error at line 184 in :
/omd/sites/${site}/share/check_mk/checks/local

--

Beste Grüße

Ghassan Elrayah

Mail: ghassan.elrayah@live.de

checkmk-en-bounces@lists.mathias-kettner.deOn Behalf Of
Sent:
To:
checkmk-en@lists.mathias-kettner.de
Subject:


-- Beste Grüße
Ghassan Elrayah
Mail:

ghassan.elrayah@live.de


_______________________________________________
checkmk-en mailing list
Manage your subscription or unsubscribe

checkmk-en@lists.mathias-kettner.dehttps://lists.mathias-kettner.de/cgi-bin/mailman/listinfo/checkmk-en


-- Beste Grüße
Ghassan Elrayah
Mail:

ghassan.elrayah@live.de