cmk.gui.plugins.wato.SNMPCredentials for new form_specs API?

r.sander · May 23, 2025, 3:29pm

Hi,

I am currently trying to migrate the ruleset for check_snmp where cmk.gui.plugins.wato.SNMPCredentials is in use.

When this is used in a new style ruleset the application throws an exception: AttributeError: 'Alternative' object has no attribute 'migrate'.

How do I migrate my ruleset?

github.com

HeinleinSupport/check_mk_extensions/blob/cmk2.3/check_snmp/web/plugins/wato/active_checks_snmp.py

#!/usr/bin/env python3
# -*- encoding: utf-8; py-indent-offset: 4 -*-

#
# (c) 2013 Heinlein Support GmbH
#          Robert Sander <r.sander@heinlein-support.de>
#

# This is free software;  you can redistribute it and/or modify it
# under the  terms of the  GNU General Public License  as published by
# the Free Software Foundation in version 2.  This file is distributed
# in the hope that it will be useful, but WITHOUT ANY WARRANTY;  with-
# out even the implied warranty of  MERCHANTABILITY  or  FITNESS FOR A
# PARTICULAR PURPOSE. See the  GNU General Public License for more de-
# ails.  You should have  received  a copy of the  GNU  General Public
# License along with GNU Make; see the file  COPYING.  If  not,  write
# to the Free Software Foundation, Inc., 51 Franklin St,  Fifth Floor,
# Boston, MA 02110-1301 USA.

from cmk.gui.i18n import _

This file has been truncated. show original

r.sander · May 30, 2025, 12:29pm

Hi @moritz,

why is SNMPCredentials() still returning an Alternative() in the git master branch?

github.com

Checkmk/checkmk/blob/master/cmk/gui/watolib/attributes.py#L73


      
                      "password": form_specs.DictElement(
                          required=True,
                          parameter_form=SimplePassword(
                              title=Title("Password"), custom_validate=[not_empty()]
                          ),
                      ),
                  },
              )
          
          
          def SNMPCredentials(
              title: str | None = None,
              help: ValueSpecHelp | None = None,
              only_v3: bool = False,
              default_value: str | None = "public",
              allow_none: bool = False,
              for_ec: bool = False,
          ) -> Alternative:
              def alternative_match(x: object) -> Literal[0, 1, 2, 3]:
                  if not isinstance(x, tuple | str | NoneType):
                      raise MKGeneralException("invalid SNMP credential type %s" % type(x))

Shouldn’t this also use the form_specs API you force us to use?

r.sander · July 16, 2025, 1:43pm

There should be a wrapper for the converter to tell not to convert this ValueSpec.

moritz · July 16, 2025, 2:04pm

Found it. It’s only in 2.4 though. Grep for LegacyValueSpec.